Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Current Speaker if nobody speaks #2071

Merged

Conversation

CakeVR
Copy link
Collaborator

@CakeVR CakeVR commented Feb 4, 2024

In the case that a text line has no speaker or Dialogic is outside of a timeline, the current_speaker method crashes.

This PR handles invalid character values and returns null. On top, this adds unit tests.

CakeVR and others added 2 commits February 4, 2024 14:24

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
There is no speaker if the game is outside a timeline or if the current text line is not spoken by a character.

Verified

This commit was signed with the committer’s verified signature.
CakeVR Cake
@CakeVR CakeVR added the Enhance ⚡ Improve a feature's workflow. label Feb 4, 2024
@CakeVR CakeVR added this to the Version 2.0 (beta) milestone Feb 4, 2024

Verified

This commit was signed with the committer’s verified signature.
CakeVR Cake
@CakeVR CakeVR merged commit 758abb5 into dialogic-godot:main Feb 4, 2024
2 checks passed
@CakeVR CakeVR deleted the fix-current-speaker-if-nobody-speaks branch February 4, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhance ⚡ Improve a feature's workflow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants